expression: support JSON for builtin function COALESCE #9087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Zhang <[email protected]>
|
/run-all-tests |
|
@zz-jason CI failed, PTAL |
alivxxx
reviewed
Jan 17, 2019
eurekaka
reviewed
Jan 22, 2019
| @@ -202,6 +202,9 @@ func (c *coalesceFunctionClass) getFunction(ctx sessionctx.Context, args []Expre | |||
| } | |||
| sig = &builtinCoalesceDurationSig{bf} | |||
| sig.setPbCode(tipb.ScalarFuncSig_CoalesceDuration) | |||
| case types.ETJson: | |||
| sig = &builtinCoalesceJsonSig{bf} | |||
| sig.setPbCode(tipb.ScalarFuncSig_CoalesceJson) | |||
There was a problem hiding this comment.
We need to update getSignatureByPB as well.
There was a problem hiding this comment.
getSignatureByPB is only used in mocktikv when this function is pushed to the coprocessor. I think we can do it later when we push it?
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9087 +/- ##
==========================================
- Coverage 67.21% 67.19% -0.02%
==========================================
Files 371 371
Lines 76945 76958 +13
==========================================
- Hits 51721 51715 -6
- Misses 20606 20622 +16
- Partials 4618 4621 +3
Continue to review full report at Codecov.
|
XuHuaiyu
added
status/LGT2
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Jan 28, 2019
zz-jason
added a commit
that referenced
this pull request
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Zhang [email protected]
What problem does this PR solve?
Support JSON type for builtin function COALESCE, to avoid panic once we returned a nil pointer.
What is changed and how it works?
As the above said.
Check List
Tests
Related changes